Minerva: audit `github.server_url` + `github.repository` expressions on Forgejo Actions #2

New issue

Closed

opened 2026-04-20 17:22:12 +00:00 by claude-bot · 1 comment

claude-bot commented

2026-04-20 17:22:12 +00:00

Collaborator

Context

Per memory reference reference_forgejo_secret_prefix.md, github.server_url and github.repository expressions are unreliable on Forgejo Actions (unlike on actual GitHub Actions).

Surfaced while reviewing Minerva PR #253. The new success-ntfy messages build a Run URL with:

Run: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}

This pattern is already used in 8+ pre-existing Minerva workflows (pipeline.yml, rls.yml, directus.yml, export-lint.yml, health-backup.yml, health-pgbouncer.yml, health-directus.yml, plus the deploy/drift failure blocks). If the expressions render wrong on Forgejo, every ntfy notification is linking to a broken URL.

What to check

Trigger any workflow that uses these expressions (a failure ntfy on a test branch is easiest).
Inspect the ntfy message body in the actual delivered notification.
Verify the rendered URL opens the correct Forgejo Actions run page.

If broken, replace with hard-coded server URL + github.run_id or a Forgejo-native equivalent. If working, document that Forgejo does populate these expressions so the memory note can be updated.

Scope

Minerva repo only. Other projects don't currently use ntfy pings of this shape.

Not blocking

Minerva issue #251 / PR #253 landed with this pattern because it matches 8 pre-existing workflows — the risk is pre-existing, not introduced. This ticket closes the loop.

## Context Per memory reference `reference_forgejo_secret_prefix.md`, `github.server_url` and `github.repository` expressions are **unreliable on Forgejo Actions** (unlike on actual GitHub Actions). Surfaced while reviewing Minerva PR #253. The new success-ntfy messages build a Run URL with: ```yaml Run: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }} ``` This pattern is already used in **8+ pre-existing Minerva workflows** (`pipeline.yml`, `rls.yml`, `directus.yml`, `export-lint.yml`, `health-backup.yml`, `health-pgbouncer.yml`, `health-directus.yml`, plus the deploy/drift failure blocks). If the expressions render wrong on Forgejo, every ntfy notification is linking to a broken URL. ## What to check 1. Trigger any workflow that uses these expressions (a failure ntfy on a test branch is easiest). 2. Inspect the ntfy message body in the actual delivered notification. 3. Verify the rendered URL opens the correct Forgejo Actions run page. If broken, replace with hard-coded server URL + `github.run_id` or a Forgejo-native equivalent. If working, document that Forgejo does populate these expressions so the memory note can be updated. ## Scope Minerva repo only. Other projects don't currently use ntfy pings of this shape. ## Not blocking Minerva issue #251 / PR #253 landed with this pattern because it matches 8 pre-existing workflows — the risk is pre-existing, not introduced. This ticket closes the loop.

claude-bot commented

2026-04-20 18:28:59 +00:00

Author

Collaborator