review-orchestrator: `needs-human-review` label referenced in policy doesn't exist in mike/Minerva #5

New issue

Closed

opened 2026-04-20 20:52:25 +00:00 by claude-bot · 1 comment

claude-bot commented

2026-04-20 20:52:25 +00:00

Collaborator

Problem

docs/review-orchestrator-policy.md in mike/Minerva instructs the orchestrator to apply a needs-human-review label on ESCALATE verdicts. Surfaced during the dry-run review of PR #303 when the orchestrator returned ESCALATE and couldn't find the label.

Actual labels in mike/Minerva:

disable-auto-merge
do-not-merge
hold
wip

None of those map cleanly to "human should look at this PR before merging". hold is close but it's documented as "do not merge" which conflates intent.

Options

Create the label in mike/Minerva with description "Specialist reviewers escalated — a human should look at this PR before merging" and a distinctive color. Lowest-friction fix.
Rewrite the policy to use hold for escalations, acknowledging the conflation.
Rewrite the policy to skip the label step entirely and rely on the verdict comment alone.

Recommended: (1). Orchestrator behavior is cleaner when the policy-vs-repo state matches.

Where

Repo: mike/Minerva
Policy doc: docs/review-orchestrator-policy.md (the ESCALATE branch)
Orchestrator agent: .claude/agents/review-orchestrator.md
First observed: mike/Minerva#303 dry-run (2026-04-20)

Acceptance

needs-human-review label exists in mike/Minerva (or policy updated to match what exists)
Orchestrator can apply the label without a "label does not exist" warning on ESCALATE verdicts

Low-priority, non-blocking.

## Problem `docs/review-orchestrator-policy.md` in `mike/Minerva` instructs the orchestrator to apply a `needs-human-review` label on ESCALATE verdicts. Surfaced during the dry-run review of PR #303 when the orchestrator returned ESCALATE and couldn't find the label. Actual labels in `mike/Minerva`: - `disable-auto-merge` - `do-not-merge` - `hold` - `wip` None of those map cleanly to "human should look at this PR before merging". `hold` is close but it's documented as "do not merge" which conflates intent. ## Options 1. **Create the label** in `mike/Minerva` with description "Specialist reviewers escalated — a human should look at this PR before merging" and a distinctive color. Lowest-friction fix. 2. **Rewrite the policy** to use `hold` for escalations, acknowledging the conflation. 3. **Rewrite the policy** to skip the label step entirely and rely on the verdict comment alone. Recommended: (1). Orchestrator behavior is cleaner when the policy-vs-repo state matches. ## Where - Repo: `mike/Minerva` - Policy doc: `docs/review-orchestrator-policy.md` (the ESCALATE branch) - Orchestrator agent: `.claude/agents/review-orchestrator.md` - First observed: https://code.rinaldifamily.org/mike/Minerva/pulls/303 dry-run (2026-04-20) ## Acceptance - [ ] `needs-human-review` label exists in `mike/Minerva` (or policy updated to match what exists) - [ ] Orchestrator can apply the label without a "label does not exist" warning on ESCALATE verdicts Low-priority, non-blocking.

claude-bot commented

2026-07-22 05:40:03 +00:00

Author

Collaborator

Closed as already resolved in the owning project by mike/Minerva#413. Verified on 2026-07-22: the live needs-human-review label exists with the intended escalation description, and .forgejo/workflows/bootstrap-labels.yml on main contains the seed entry. No duplicate issue is needed.

Closed as already resolved in the owning project by [mike/Minerva#413](https://code.rinaldifamily.org/mike/Minerva/issues/413). Verified on 2026-07-22: the live `needs-human-review` label exists with the intended escalation description, and `.forgejo/workflows/bootstrap-labels.yml` on `main` contains the seed entry. No duplicate issue is needed.

claude-bot closed this issue

2026-07-22 05:40:07 +00:00